feat: enable TypeScript strict mode#2761

Merged

setchy merged 8 commits intomainfrom

enable-strict-mode

Apr 3, 2026

Member

afonsojramos commented Apr 2, 2026

Summary

Enables "strict": true in tsconfig.json
Fixes ~292 strict mode errors across 94 files
Makes generic onMainEvent/handleMainEvent IPC helpers to avoid type casting at every call site
Adds proper null guards in notification handlers (discussion, issue, pullRequest)
Changes timer hooks to accept number | null delay parameter
Updates globalError type from GitifyError to GitifyError | undefined
Converts null to undefined in optional Gitify type fields for consistency
Adds err as Error casts in catch blocks
All 931 tests pass

Test plan

pnpm tsc --noEmit passes with zero errors
All 133 test files pass (931 tests)
Biome lint and format checks pass

afonsojramos added 3 commits

April 2, 2026 04:29


          feat: enable strict mode in TypeScript config

c3fa5cc


          fix: resolve strict mode errors in main process

8c217ea


          fix: resolve strict mode errors in renderer process

970d4cb

afonsojramos requested review from bmulholland and setchy as code owners

April 2, 2026 02:33

github-actions bot added the enhancement label

setchy requested changes

View reviewed changes

Member

setchy left a comment

Thanks @afonsojramos - spotted a few areas of feedback, will provide more detail when I'm in front of my computer next (currently on mobile)

setchy reviewed

View reviewed changes

src/main/lifecycle/reset.ts Show resolved Hide resolved

setchy reviewed

View reviewed changes

src/main/lifecycle/window.ts Outdated Show resolved Hide resolved

setchy reviewed

View reviewed changes

src/main/lifecycle/window.ts Outdated Show resolved Hide resolved

setchy reviewed

View reviewed changes

src/renderer/utils/system/native.ts Outdated Show resolved Hide resolved

setchy reviewed

View reviewed changes

src/main/handlers/storage.ts Outdated Show resolved Hide resolved

afonsojramos added 3 commits

April 2, 2026 19:09


          refactor: use early return guard for mb.window across src/main

fd4789a


          fix: restore null semantics for native notification url parameter

a2adc75


          refactor: replace err as Error casts with toError utility

02e8d14

afonsojramos requested a review from setchy

April 3, 2026 00:55

setchy approved these changes

View reviewed changes

setchy added 2 commits

April 2, 2026 22:26


          address sonar feedback

9f8a09f

Signed-off-by: Adam Setch <adam.setch@outlook.com>


          address sonar feedback

Signed-off-by: Adam Setch <adam.setch@outlook.com>

setchy merged commit 27b9554 into main

9 checks passed

setchy deleted the enable-strict-mode branch

April 3, 2026 02:30

github-actions bot added this to the Release 7.0.0 milestone

sonarqubecloud bot commented Apr 3, 2026

Quality Gate failed

Failed conditions
68.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels